[SPARK-3873] [build] Enable import ordering error checking.#10612
[SPARK-3873] [build] Enable import ordering error checking.#10612vanzin wants to merge 9 commits intoapache:masterfrom
Conversation
Turn import ordering violations into build errors, plus a few adjustments to account for how the checker behaves. I'm a little on the fence about whether the existing code is right, but it's easier to appease the checker than to discuss what's the more correct order here. Plus a few fixes to imports that cropped in since my recent cleanups.
|
I'll let this simmer for a few days to wait for new PRs that might have violations to go in, and fix those... but at some point I'll get bored of fixing things and probably push this. |
|
Test build #48816 has finished for PR 10612 at commit
|
|
retest this please |
|
Test build #48834 has finished for PR 10612 at commit
|
|
Test build #48862 has finished for PR 10612 at commit
|
scalastyle-config.xml
Outdated
There was a problem hiding this comment.
you'd need to remove this line
|
Test build #48888 has finished for PR 10612 at commit
|
|
LGTM. |
|
You should probably just find a slow day (Sat night / Sun morning?) to bring this up to date and merge it. |
|
Will probably do that Monday morning (or Sunday evening if I'm feeling bored). |
|
Test build #49077 has finished for PR 10612 at commit
|
|
Test build #49081 has finished for PR 10612 at commit
|
|
I've merged this. Thanks. |
3 participants
Turn import ordering violations into build errors, plus a few adjustments
to account for how the checker behaves. I'm a little on the fence about
whether the existing code is right, but it's easier to appease the checker
than to discuss what's the more correct order here.
Plus a few fixes to imports that cropped in since my recent cleanups.